snapshot of https://github.com/zulip/zulip.git @ 48c69911c7dd4e03b20552eb3bd77ad8151c1357 (2026-09-15)
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
This commit is contained in:
112
zerver/lib/recipient_users.py
Normal file
112
zerver/lib/recipient_users.py
Normal file
@@ -0,0 +1,112 @@
|
||||
from collections.abc import Sequence
|
||||
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.utils.translation import gettext as _
|
||||
|
||||
from zerver.lib.exceptions import JsonableError
|
||||
from zerver.lib.users import has_inaccessible_users
|
||||
from zerver.models import DirectMessageGroup, Recipient, UserProfile
|
||||
from zerver.models.recipients import (
|
||||
get_direct_message_group_hash,
|
||||
get_or_create_direct_message_group,
|
||||
)
|
||||
from zerver.models.users import is_cross_realm_bot_email
|
||||
|
||||
|
||||
def get_recipient_from_user_profiles(
|
||||
recipient_profiles: Sequence[UserProfile],
|
||||
forwarded_mirror_message: bool,
|
||||
forwarder_user_profile: UserProfile | None,
|
||||
sender: UserProfile,
|
||||
create: bool = True,
|
||||
) -> Recipient:
|
||||
# Avoid mutating the passed in list of recipient_profiles.
|
||||
recipient_profiles_map = {user_profile.id: user_profile for user_profile in recipient_profiles}
|
||||
|
||||
if forwarded_mirror_message:
|
||||
# In our mirroring integrations with some third-party
|
||||
# protocols, bots subscribed to the third-party protocol
|
||||
# forward to Zulip messages that they received in the
|
||||
# third-party service. The permissions model for that
|
||||
# forwarding is that users can only submit to Zulip private
|
||||
# messages they personally received, and here we do the check
|
||||
# for whether forwarder_user_profile is among the private
|
||||
# message recipients of the message.
|
||||
assert forwarder_user_profile is not None
|
||||
if forwarder_user_profile.id not in recipient_profiles_map:
|
||||
raise ValidationError(_("User not authorized for this query"))
|
||||
|
||||
# Make sure the sender is included in the group direct messages.
|
||||
recipient_profiles_map[sender.id] = sender
|
||||
user_ids = list(recipient_profiles_map)
|
||||
|
||||
if create:
|
||||
direct_message_group = get_or_create_direct_message_group(user_ids)
|
||||
else:
|
||||
# We intentionally let the DirectMessageGroup.DoesNotExist escape,
|
||||
# in the case that there is no such direct message group, and the
|
||||
# user passed create=False
|
||||
direct_message_group = DirectMessageGroup.objects.get(
|
||||
huddle_hash=get_direct_message_group_hash(user_ids)
|
||||
)
|
||||
return Recipient(
|
||||
id=direct_message_group.recipient_id,
|
||||
type=Recipient.DIRECT_MESSAGE_GROUP,
|
||||
type_id=direct_message_group.id,
|
||||
)
|
||||
|
||||
|
||||
def validate_recipient_user_profiles(
|
||||
user_profiles: Sequence[UserProfile], sender: UserProfile, allow_deactivated: bool = False
|
||||
) -> Sequence[UserProfile]:
|
||||
recipient_profiles_map: dict[int, UserProfile] = {}
|
||||
|
||||
# We exempt cross-realm bots from the check that all the recipients
|
||||
# are in the same realm.
|
||||
realms = set()
|
||||
if not is_cross_realm_bot_email(sender.email):
|
||||
realms.add(sender.realm_id)
|
||||
|
||||
for user_profile in user_profiles:
|
||||
if (
|
||||
not user_profile.is_active
|
||||
and not user_profile.is_mirror_dummy
|
||||
and not allow_deactivated
|
||||
) or user_profile.realm.deactivated:
|
||||
raise ValidationError(
|
||||
_("'{email}' is no longer using Zulip.").format(email=user_profile.email)
|
||||
)
|
||||
recipient_profiles_map[user_profile.id] = user_profile
|
||||
if not is_cross_realm_bot_email(user_profile.email):
|
||||
realms.add(user_profile.realm_id)
|
||||
|
||||
if len(realms) > 1:
|
||||
raise ValidationError(_("You can't send direct messages outside of your organization."))
|
||||
|
||||
return list(recipient_profiles_map.values())
|
||||
|
||||
|
||||
def recipient_for_user_profiles(
|
||||
user_profiles: Sequence[UserProfile],
|
||||
forwarded_mirror_message: bool,
|
||||
forwarder_user_profile: UserProfile | None,
|
||||
sender: UserProfile,
|
||||
*,
|
||||
allow_deactivated: bool = False,
|
||||
create: bool = True,
|
||||
) -> Recipient:
|
||||
recipient_profiles = validate_recipient_user_profiles(
|
||||
user_profiles, sender, allow_deactivated=allow_deactivated
|
||||
)
|
||||
|
||||
return get_recipient_from_user_profiles(
|
||||
recipient_profiles, forwarded_mirror_message, forwarder_user_profile, sender, create=create
|
||||
)
|
||||
|
||||
|
||||
def check_sender_can_access_recipients(
|
||||
sender: UserProfile, user_profiles: Sequence[UserProfile]
|
||||
) -> None:
|
||||
recipient_user_ids = [user.id for user in user_profiles]
|
||||
if has_inaccessible_users(recipient_user_ids, sender):
|
||||
raise JsonableError(_("You do not have permission to access some of the recipients."))
|
||||
Reference in New Issue
Block a user