snapshot of https://github.com/zulip/zulip.git @ 48c69911c7dd4e03b20552eb3bd77ad8151c1357 (2026-09-15)
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
This commit is contained in:
70
zerver/views/thumbnail.py
Normal file
70
zerver/views/thumbnail.py
Normal file
@@ -0,0 +1,70 @@
|
||||
import re
|
||||
|
||||
from django.contrib.auth.models import AnonymousUser
|
||||
from django.http import HttpRequest, HttpResponseBase, HttpResponseForbidden
|
||||
from django.utils.translation import gettext as _
|
||||
|
||||
from zerver.lib.attachments import validate_attachment_request
|
||||
from zerver.lib.exceptions import JsonableError
|
||||
from zerver.lib.response import json_success
|
||||
from zerver.lib.thumbnail import missing_thumbnails
|
||||
from zerver.lib.typed_endpoint import PathOnly, typed_endpoint
|
||||
from zerver.models import ImageAttachment, UserProfile
|
||||
from zerver.views.upload import serve_file
|
||||
|
||||
|
||||
@typed_endpoint
|
||||
def backend_serve_thumbnail(
|
||||
request: HttpRequest,
|
||||
maybe_user_profile: UserProfile | AnonymousUser,
|
||||
*,
|
||||
size: str,
|
||||
url: str,
|
||||
) -> HttpResponseBase:
|
||||
# This URL used to be passed arbitrary URLs, and pass them through
|
||||
# Camo; we no longer support doing so, and instead return a 403.
|
||||
#
|
||||
# Modern thumbnailing uses URLs of the style
|
||||
# `/user_uploads/thumbnail/.../300x200.webp`; this endpoint is
|
||||
# kept for backward compatibility, and for future extension for
|
||||
# thumbnailing external URLs.
|
||||
upload_path_parts = re.match(r"user_uploads/(\d+)/(.*)", url)
|
||||
if not upload_path_parts:
|
||||
return HttpResponseForbidden()
|
||||
|
||||
realm_id_str = upload_path_parts[1]
|
||||
path_id = upload_path_parts[2]
|
||||
|
||||
# We do not have ImageAttachment rows for historical uploads, so
|
||||
# we cannot serve a "new" thumbnail for these requests; serve the
|
||||
# full-size file.
|
||||
return serve_file(request, maybe_user_profile, realm_id_str, path_id)
|
||||
|
||||
|
||||
@typed_endpoint
|
||||
def check_thumbnail_status(
|
||||
request: HttpRequest,
|
||||
user_profile: UserProfile,
|
||||
*,
|
||||
realm_id_str: PathOnly[str],
|
||||
filename: PathOnly[str],
|
||||
) -> HttpResponseBase:
|
||||
path_id = f"{realm_id_str}/{filename}"
|
||||
|
||||
if not validate_attachment_request(user_profile, path_id)[0]:
|
||||
# Technically, there are 2 cases here:
|
||||
# * The user put something in their compose box that has the form
|
||||
# of an upload URL, but does not actually correspond to a previously
|
||||
# uploaded file. validate_attachment_request will return None.
|
||||
# * The user is polling thumbnail status for a file they don't have
|
||||
# permission to access. validate_attachment_request will return False.
|
||||
raise JsonableError(_("Invalid attachment"))
|
||||
|
||||
try:
|
||||
image_attachment = ImageAttachment.objects.get(path_id=path_id)
|
||||
except ImageAttachment.DoesNotExist:
|
||||
raise JsonableError(_("Invalid attachment"))
|
||||
|
||||
needed_thumbnails = missing_thumbnails(image_attachment)
|
||||
|
||||
return json_success(request, data={"has_thumbnail": len(needed_thumbnails) == 0})
|
||||
Reference in New Issue
Block a user