Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
170 lines
4.3 KiB
Go
170 lines
4.3 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package jobs_test
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/jobs"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestBatchWorkerRace tests race conditions during the start/stop
|
|
// cases of the batch worker. Use the -race flag while testing this.
|
|
func TestBatchWorkerRace(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
th := Setup(t)
|
|
|
|
worker := jobs.MakeBatchWorker(th.Server.Jobs, th.Server.Store(), 1*time.Second, func(rctx request.CTX, job *model.Job) bool {
|
|
return false
|
|
})
|
|
|
|
go worker.Run()
|
|
worker.Stop()
|
|
}
|
|
|
|
func TestBatchWorker(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
createBatchWorker := func(t *testing.T, th *TestHelper, doBatch func(rctx request.CTX, job *model.Job) bool) (*jobs.BatchWorker, *model.Job) {
|
|
t.Helper()
|
|
|
|
worker := jobs.MakeBatchWorker(th.Server.Jobs, th.Server.Store(), 1*time.Second, doBatch)
|
|
job := th.SetupBatchWorker(t, worker)
|
|
return worker, job
|
|
}
|
|
|
|
getBatchNumberFromData := func(t *testing.T, data model.StringMap) int {
|
|
t.Helper()
|
|
|
|
batchNumber, err := strconv.Atoi(data["batch_number"])
|
|
require.NoError(t, err)
|
|
|
|
return batchNumber
|
|
}
|
|
|
|
incrementBatchNumber := func(t *testing.T, th *TestHelper, job *model.Job) {
|
|
t.Helper()
|
|
|
|
batchNumber, err := strconv.Atoi(job.Data["batch_number"])
|
|
require.NoError(t, err)
|
|
|
|
batchNumber++
|
|
job.Data["batch_number"] = strconv.Itoa(batchNumber)
|
|
appErr := th.Server.Jobs.SetJobProgress(job, 0)
|
|
require.Nil(t, appErr)
|
|
}
|
|
|
|
t.Run("stop after first batch", func(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
var worker *jobs.BatchWorker
|
|
worker, job := createBatchWorker(t, th, func(rctx request.CTX, job *model.Job) bool {
|
|
batchNumber := getBatchNumberFromData(t, job.Data)
|
|
|
|
require.Equal(t, 1, batchNumber, "only batch 1 should have run")
|
|
|
|
// Shut down the worker after the first batch to prevent subsequent ones.
|
|
if batchNumber >= 1 {
|
|
go worker.Stop()
|
|
} else {
|
|
incrementBatchNumber(t, th, job)
|
|
}
|
|
|
|
return false
|
|
})
|
|
|
|
// Queue the work to be done
|
|
worker.JobChannel() <- *job
|
|
|
|
th.WaitForJobStatus(t, job, model.JobStatusPending)
|
|
th.WaitForBatchNumber(t, job, 1)
|
|
})
|
|
|
|
t.Run("stop after second batch", func(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
var worker *jobs.BatchWorker
|
|
worker, job := createBatchWorker(t, th, func(rctx request.CTX, job *model.Job) bool {
|
|
batchNumber := getBatchNumberFromData(t, job.Data)
|
|
|
|
require.LessOrEqual(t, batchNumber, 2, "only batches 1 and 2 should have run")
|
|
|
|
// Shut down the worker after the second batch to prevent subsequent ones.
|
|
if batchNumber >= 2 {
|
|
go worker.Stop()
|
|
} else {
|
|
incrementBatchNumber(t, th, job)
|
|
}
|
|
|
|
return false
|
|
})
|
|
|
|
// Queue the work to be done
|
|
worker.JobChannel() <- *job
|
|
|
|
th.WaitForJobStatus(t, job, model.JobStatusPending)
|
|
th.WaitForBatchNumber(t, job, 2)
|
|
})
|
|
|
|
t.Run("done after first batch", func(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
var worker *jobs.BatchWorker
|
|
worker, job := createBatchWorker(t, th, func(rctx request.CTX, job *model.Job) bool {
|
|
batchNumber := getBatchNumberFromData(t, job.Data)
|
|
require.Equal(t, 1, batchNumber, "only batch 1 should have run")
|
|
|
|
if batchNumber >= 1 {
|
|
go worker.Stop() // Shut down the worker when the job is done
|
|
return true
|
|
}
|
|
|
|
incrementBatchNumber(t, th, job)
|
|
return false
|
|
})
|
|
|
|
// Queue the work to be done
|
|
worker.JobChannel() <- *job
|
|
|
|
th.WaitForBatchNumber(t, job, 1)
|
|
})
|
|
|
|
t.Run("done after three batches", func(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
var worker *jobs.BatchWorker
|
|
worker, job := createBatchWorker(t, th, func(rctx request.CTX, job *model.Job) bool {
|
|
batchNumber := getBatchNumberFromData(t, job.Data)
|
|
require.LessOrEqual(t, batchNumber, 3, "only 3 batches should have run")
|
|
|
|
if batchNumber >= 3 {
|
|
go worker.Stop() // Shut down the worker when the job is done
|
|
return true
|
|
}
|
|
|
|
incrementBatchNumber(t, th, job)
|
|
return false
|
|
})
|
|
|
|
// Queue the work to be done
|
|
worker.JobChannel() <- *job
|
|
|
|
th.WaitForBatchNumber(t, job, 3)
|
|
})
|
|
}
|