Files
upstream-twenty/packages/twenty-oxlint-rules/rules/matching-state-variable.ts
upstream-mirror e7da97194a
Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
snapshot of https://github.com/twentyhq/twenty.git (main, 2026-09-17; blobs > 131072B omitted)
2026-09-17 23:28:13 +05:00

251 lines
7.0 KiB
TypeScript

import { defineRule } from '@oxlint/plugins';
export const RULE_NAME = 'matching-state-variable';
const VALUE_HOOKS = [
'useAtomStateValue',
'useAtomComponentStateValue',
'useAtomFamilyStateValue',
'useAtomComponentFamilyStateValue',
];
const STATE_HOOKS = [
'useAtomState',
'useAtomComponentState',
'useAtomComponentFamilyState',
];
const SETTER_HOOKS = [
'useSetAtomState',
'useSetAtomComponentState',
'useSetAtomFamilyState',
'useSetAtomComponentFamilyState',
];
const FAMILY_HOOKS = new Set([
'useAtomFamilyStateValue',
'useAtomComponentFamilyStateValue',
'useAtomComponentFamilyState',
'useSetAtomFamilyState',
'useSetAtomComponentFamilyState',
]);
const ALL_HOOKS = [...VALUE_HOOKS, ...STATE_HOOKS, ...SETTER_HOOKS];
const SUFFIX_PATTERN =
/(ComponentFamilyState|ComponentState|ScopedFamilyState|FamilyState|ScopedState|ScopedSelector|Selector|State)$/;
const getExpectedBaseName = (stateArgName: string): string =>
stateArgName.replace(SUFFIX_PATTERN, '');
const getExpectedSetterName = (baseName: string): string =>
`set${baseName.charAt(0).toUpperCase()}${baseName.slice(1)}`;
// Family hooks may suffix the string-literal key to disambiguate multiple
// reads of the same family in one scope (e.g. metadataStore / metadataStoreViews).
const getFamilyKeyVariants = (
hookName: string,
args: ReadonlyArray<any> | undefined,
): string[] => {
if (!FAMILY_HOOKS.has(hookName) || !args) {
return [];
}
const familyKeyArg = args[1];
if (
familyKeyArg?.type !== 'Literal' ||
typeof familyKeyArg.value !== 'string' ||
familyKeyArg.value.length === 0
) {
return [];
}
const keyValue = familyKeyArg.value;
return [`${keyValue.charAt(0).toUpperCase()}${keyValue.slice(1)}`];
};
export const rule = defineRule({
meta: {
type: 'problem',
docs: {
description:
'Ensure state value and setter are named after their atom name',
},
fixable: 'code',
schema: [],
messages: {
invalidVariableName:
"Invalid usage of {{ hookName }}: the variable should be named '{{ expectedName }}' but found '{{ actualName }}'.",
invalidSetterName:
"Invalid usage of {{ hookName }}: Expected setter '{{ expectedName }}' but found '{{ actualName }}'.",
},
},
create: (context) => {
return {
VariableDeclarator: (node: any) => {
if (
node?.init?.type !== 'CallExpression' ||
node.init.callee?.type !== 'Identifier' ||
!ALL_HOOKS.includes(node.init.callee.name)
) {
return;
}
const hookName = node.init.callee.name;
const stateNameBase =
node.init.arguments[0]?.type === 'Identifier'
? node.init.arguments[0].name
: undefined;
if (!stateNameBase) {
return;
}
const expectedVariableNameBase = getExpectedBaseName(stateNameBase);
const familyKeySuffixes = getFamilyKeyVariants(
hookName,
node.init.arguments,
);
const acceptedVariableNames = [
expectedVariableNameBase,
...familyKeySuffixes.map(
(suffix) => `${expectedVariableNameBase}${suffix}`,
),
];
const acceptedSetterNames = acceptedVariableNames.map(
getExpectedSetterName,
);
if (SETTER_HOOKS.includes(hookName)) {
if (node.id?.type === 'Identifier') {
const actualName = node.id.name;
if (!acceptedSetterNames.includes(actualName)) {
context.report({
node,
messageId: 'invalidSetterName',
data: {
hookName: stateNameBase,
actualName,
expectedName: acceptedSetterNames[0],
},
fix: (fixer) =>
fixer.replaceText(node.id, acceptedSetterNames[0]),
});
}
}
return;
}
if (VALUE_HOOKS.includes(hookName)) {
if (node.id?.type === 'Identifier') {
const actualName = node.id.name;
if (!acceptedVariableNames.includes(actualName)) {
context.report({
node,
messageId: 'invalidVariableName',
data: {
actualName,
expectedName: acceptedVariableNames[0],
hookName: stateNameBase,
callee: hookName,
},
fix: (fixer) =>
fixer.replaceText(node.id, acceptedVariableNames[0]),
});
}
}
return;
}
if (node.id?.type === 'Identifier') {
const actualVariableName = node.id.name;
if (!acceptedVariableNames.includes(actualVariableName)) {
context.report({
node,
messageId: 'invalidVariableName',
data: {
actualName: actualVariableName,
expectedName: acceptedVariableNames[0],
hookName: stateNameBase,
callee: hookName,
},
fix: (fixer) =>
fixer.replaceText(node.id, acceptedVariableNames[0]),
});
}
return;
}
if (node.id.type === 'ArrayPattern') {
const actualVariableName =
node.id.elements?.[0]?.type === 'Identifier'
? node.id.elements[0].name
: undefined;
if (
actualVariableName &&
!acceptedVariableNames.includes(actualVariableName)
) {
context.report({
node,
messageId: 'invalidVariableName',
data: {
actualName: actualVariableName,
expectedName: acceptedVariableNames[0],
hookName: stateNameBase,
callee: hookName,
},
fix: (fixer) => {
if (node.id.type === 'ArrayPattern') {
return fixer.replaceText(
node.id.elements[0] as any,
acceptedVariableNames[0],
);
}
return null;
},
});
}
if (node.id.elements[1]?.type === 'Identifier') {
const actualSetterName = node.id.elements[1].name;
if (!acceptedSetterNames.includes(actualSetterName)) {
context.report({
node,
messageId: 'invalidSetterName',
data: {
hookName: stateNameBase,
actualName: actualSetterName,
expectedName: acceptedSetterNames[0],
},
fix: (fixer) => {
if (node.id.type === 'ArrayPattern') {
return fixer.replaceText(
node.id.elements[1]!,
acceptedSetterNames[0],
);
}
return null;
},
});
}
}
}
},
};
},
});