Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
195 lines
6.2 KiB
TypeScript
195 lines
6.2 KiB
TypeScript
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
|
|
import {
|
|
createWebhook,
|
|
createWebhookReceiver,
|
|
deleteWebhook,
|
|
} from 'test/integration/metadata/suites/utils/webhook-test.util';
|
|
import { makeAdminPanelAPIRequest } from 'test/integration/twenty-config/utils/make-admin-panel-api-request.util';
|
|
import { expectEventually } from 'test/integration/utils/expect-eventually.util';
|
|
import { getCoreRepository } from 'test/integration/utils/get-core-repository.util';
|
|
|
|
import { gql } from 'graphql-tag';
|
|
import { createClient } from 'redis';
|
|
import { FeatureFlagKey } from 'twenty-shared/types';
|
|
import { type Repository } from 'typeorm';
|
|
import { v4 as uuidv4 } from 'uuid';
|
|
|
|
import { FeatureFlagEntity } from 'src/engine/core-modules/feature-flag/feature-flag.entity';
|
|
import { UsageLimitEntity } from 'src/engine/core-modules/usage-limit/usage-limit.entity';
|
|
import { UsageOperationType } from 'src/engine/core-modules/usage/enums/usage-operation-type.enum';
|
|
import { UsageResourceType } from 'src/engine/core-modules/usage/enums/usage-resource-type.enum';
|
|
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
|
|
|
|
const WEBHOOK_RECEIVER_PORT = 4318;
|
|
const WINDOW_SECONDS = 60;
|
|
const LIMIT_VALUE = 2;
|
|
const PERSON_COUNT = 5;
|
|
|
|
const CREATE_CONFIG_VARIABLE_MUTATION = gql`
|
|
mutation CreateDatabaseConfigVariable($key: String!, $value: JSON!) {
|
|
createDatabaseConfigVariable(key: $key, value: $value)
|
|
}
|
|
`;
|
|
|
|
const DELETE_CONFIG_VARIABLE_MUTATION = gql`
|
|
mutation DeleteDatabaseConfigVariable($key: String!) {
|
|
deleteDatabaseConfigVariable(key: $key)
|
|
}
|
|
`;
|
|
|
|
const CREATE_PERSON_MUTATION = gql`
|
|
mutation CreatePerson($data: PersonCreateInput!) {
|
|
createPerson(data: $data) {
|
|
id
|
|
}
|
|
}
|
|
`;
|
|
|
|
const DESTROY_PERSON_MUTATION = gql`
|
|
mutation DestroyPerson($id: ID!) {
|
|
destroyPerson(id: $id) {
|
|
id
|
|
}
|
|
}
|
|
`;
|
|
|
|
describe('Webhook rate limiting', () => {
|
|
let usageLimitRepository: Repository<UsageLimitEntity>;
|
|
let featureFlagRepository: Repository<FeatureFlagEntity>;
|
|
let redis: Awaited<ReturnType<typeof createClient>>;
|
|
let usageLimitId: string;
|
|
let webhookId: string;
|
|
let receiver: Awaited<ReturnType<typeof createWebhookReceiver>>;
|
|
|
|
const createdPersonIds: string[] = [];
|
|
|
|
const invalidateWorkspaceCaches = async () => {
|
|
const keys = [
|
|
...(await redis.keys(`*featureFlagsMap:${SEED_APPLE_WORKSPACE_ID}*`)),
|
|
...(await redis.keys(`*usageLimits:${SEED_APPLE_WORKSPACE_ID}*`)),
|
|
];
|
|
|
|
if (keys.length > 0) {
|
|
await redis.del(keys);
|
|
}
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 300));
|
|
};
|
|
|
|
const createPerson = async (lastName: string) => {
|
|
const response = await makeGraphqlAPIRequest({
|
|
query: CREATE_PERSON_MUTATION,
|
|
variables: { data: { name: { firstName: 'WebhookThrottle', lastName } } },
|
|
});
|
|
|
|
expect(response.body.errors).toBeUndefined();
|
|
createdPersonIds.push(response.body.data.createPerson.id);
|
|
};
|
|
|
|
beforeAll(async () => {
|
|
jest.useRealTimers();
|
|
|
|
usageLimitRepository =
|
|
getCoreRepository<UsageLimitEntity>(UsageLimitEntity);
|
|
featureFlagRepository =
|
|
getCoreRepository<FeatureFlagEntity>(FeatureFlagEntity);
|
|
redis = await createClient({ url: process.env.REDIS_URL }).connect();
|
|
|
|
await makeAdminPanelAPIRequest({
|
|
query: CREATE_CONFIG_VARIABLE_MUTATION,
|
|
variables: { key: 'OUTBOUND_HTTP_ALLOWED_INTERNAL_HOSTS', value: ['*'] },
|
|
});
|
|
|
|
await featureFlagRepository.delete({
|
|
key: FeatureFlagKey.IS_WEBHOOK_RATE_LIMIT_ENABLED,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
await featureFlagRepository.save({
|
|
key: FeatureFlagKey.IS_WEBHOOK_RATE_LIMIT_ENABLED,
|
|
value: true,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
|
|
const [usageLimit] = await usageLimitRepository.save([
|
|
{
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
resourceType: UsageResourceType.WEBHOOK,
|
|
operationType: UsageOperationType.WEBHOOK_CALL,
|
|
spenderType: 'workspace',
|
|
spenderId: '',
|
|
limitKind: 'speed',
|
|
periodCount: WINDOW_SECONDS,
|
|
periodUnit: 'second',
|
|
meter: 'quantity',
|
|
limitValue: LIMIT_VALUE,
|
|
burstValue: LIMIT_VALUE,
|
|
},
|
|
]);
|
|
|
|
usageLimitId = usageLimit.id;
|
|
|
|
await invalidateWorkspaceCaches();
|
|
|
|
receiver = await createWebhookReceiver(WEBHOOK_RECEIVER_PORT);
|
|
|
|
const createWebhookResponse = await createWebhook({
|
|
targetUrl: `http://127.0.0.1:${WEBHOOK_RECEIVER_PORT}/webhook`,
|
|
operations: ['person.created'],
|
|
description: 'Webhook rate limiting test webhook',
|
|
secret: 'test-secret',
|
|
});
|
|
|
|
expect(createWebhookResponse.body.errors).toBeUndefined();
|
|
webhookId = createWebhookResponse.body.data.createWebhook.id;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await receiver.close();
|
|
await deleteWebhook(webhookId).catch(() => {});
|
|
|
|
for (const personId of createdPersonIds) {
|
|
await makeGraphqlAPIRequest({
|
|
query: DESTROY_PERSON_MUTATION,
|
|
variables: { id: personId },
|
|
}).catch(() => {});
|
|
}
|
|
|
|
await usageLimitRepository.delete({ id: usageLimitId });
|
|
await featureFlagRepository.delete({
|
|
key: FeatureFlagKey.IS_WEBHOOK_RATE_LIMIT_ENABLED,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
await makeAdminPanelAPIRequest({
|
|
query: DELETE_CONFIG_VARIABLE_MUTATION,
|
|
variables: { key: 'OUTBOUND_HTTP_ALLOWED_INTERNAL_HOSTS' },
|
|
}).catch(() => {});
|
|
|
|
await invalidateWorkspaceCaches();
|
|
await redis.quit();
|
|
jest.useFakeTimers();
|
|
});
|
|
|
|
it('delivers what the bucket admits and drops the rest of the burst', async () => {
|
|
const testId = uuidv4().slice(0, 8);
|
|
|
|
for (let personIndex = 0; personIndex < PERSON_COUNT; personIndex++) {
|
|
await createPerson(`Test-${testId}-${personIndex}`);
|
|
}
|
|
|
|
await expectEventually(
|
|
() => {
|
|
expect(receiver.receivedPayloads.length).toBe(LIMIT_VALUE);
|
|
},
|
|
{ timeoutMs: 30_000, intervalMs: 100 },
|
|
);
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 2_000));
|
|
|
|
expect(receiver.receivedPayloads.length).toBe(LIMIT_VALUE);
|
|
expect(receiver.receivedPayloads[0]).toMatchObject({
|
|
targetUrl: `http://127.0.0.1:${WEBHOOK_RECEIVER_PORT}/webhook`,
|
|
eventName: 'person.created',
|
|
});
|
|
}, 60_000);
|
|
});
|