Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
285 lines
9.4 KiB
TypeScript
285 lines
9.4 KiB
TypeScript
import { findManyOperationFactory } from 'test/integration/graphql/utils/find-many-operation-factory.util';
|
|
import { generateApiKeyToken } from 'test/integration/graphql/utils/generate-api-key-token.util';
|
|
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
|
|
import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
|
|
import { makeRestAPIRequest } from 'test/integration/rest/utils/make-rest-api-request.util';
|
|
import { getCoreRepository } from 'test/integration/utils/get-core-repository.util';
|
|
import { jestExpectToBeDefined } from 'test/utils/jest-expect-to-be-defined.util.test';
|
|
|
|
import { gql } from 'graphql-tag';
|
|
import { createClient } from 'redis';
|
|
import { FeatureFlagKey } from 'twenty-shared/types';
|
|
import { type Repository } from 'typeorm';
|
|
|
|
import { ApiKeyEntity } from 'src/engine/core-modules/api-key/api-key.entity';
|
|
import { FeatureFlagEntity } from 'src/engine/core-modules/feature-flag/feature-flag.entity';
|
|
import { UsageLimitEntity } from 'src/engine/core-modules/usage-limit/usage-limit.entity';
|
|
import { UsageOperationType } from 'src/engine/core-modules/usage/enums/usage-operation-type.enum';
|
|
import { UsageResourceType } from 'src/engine/core-modules/usage/enums/usage-resource-type.enum';
|
|
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
|
|
|
|
const WINDOW_SECONDS = 1;
|
|
const LIMIT_VALUE = 1;
|
|
|
|
describe('API rate limiting', () => {
|
|
let usageLimitRepository: Repository<UsageLimitEntity>;
|
|
let featureFlagRepository: Repository<FeatureFlagEntity>;
|
|
let apiKeyRepository: Repository<ApiKeyEntity>;
|
|
let redis: Awaited<ReturnType<typeof createClient>>;
|
|
let usageLimitId: string;
|
|
let apiKeyId: string;
|
|
let apiKeyToken: string;
|
|
|
|
const findCompaniesOverGraphql = () =>
|
|
makeGraphqlAPIRequest(
|
|
findManyOperationFactory({
|
|
objectMetadataSingularName: 'company',
|
|
objectMetadataPluralName: 'companies',
|
|
gqlFields: 'id',
|
|
first: 1,
|
|
}),
|
|
apiKeyToken,
|
|
);
|
|
|
|
const findCompaniesOverRest = () =>
|
|
makeRestAPIRequest({
|
|
method: 'get',
|
|
path: '/companies?limit=1',
|
|
bearer: apiKeyToken,
|
|
});
|
|
|
|
// Every test starts from a full bucket so it does not inherit whatever the
|
|
// previous one spent.
|
|
const waitForBucketRefill = () =>
|
|
new Promise((resolve) => setTimeout(resolve, WINDOW_SECONDS * 1000 + 200));
|
|
|
|
const invalidateWorkspaceCaches = async () => {
|
|
const keys = [
|
|
...(await redis.keys(`*featureFlagsMap:${SEED_APPLE_WORKSPACE_ID}*`)),
|
|
...(await redis.keys(`*usageLimits:${SEED_APPLE_WORKSPACE_ID}*`)),
|
|
];
|
|
|
|
if (keys.length > 0) {
|
|
await redis.del(keys);
|
|
}
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 300));
|
|
};
|
|
|
|
// The rule targets a key created for this suite alone. A workspace-scoped one
|
|
// would meter every caller in the seeded workspace, and deleting it here
|
|
// cannot undo that: the workspace cache memoizes resolved entries in process
|
|
// for MEMOIZER_TTL_MS, so the next spec file would still be rate limited.
|
|
const createDedicatedApiKey = async () => {
|
|
const rolesResponse = await makeMetadataAPIRequest({
|
|
query: gql`
|
|
query GetRoles {
|
|
getRoles {
|
|
id
|
|
label
|
|
}
|
|
}
|
|
`,
|
|
});
|
|
|
|
const adminRoleId = rolesResponse.body.data?.getRoles?.find(
|
|
(role: { label: string }) => role.label === 'Admin',
|
|
)?.id;
|
|
|
|
jestExpectToBeDefined(adminRoleId);
|
|
|
|
const createResponse = await makeMetadataAPIRequest({
|
|
query: gql`
|
|
mutation CreateApiKey($input: CreateApiKeyInput!) {
|
|
createApiKey(input: $input) {
|
|
id
|
|
}
|
|
}
|
|
`,
|
|
variables: {
|
|
input: {
|
|
name: 'API rate limiting test key',
|
|
expiresAt: new Date(Date.now() + 60 * 60 * 1000).toISOString(),
|
|
roleId: adminRoleId,
|
|
},
|
|
},
|
|
});
|
|
|
|
apiKeyId = createResponse.body.data?.createApiKey?.id;
|
|
jestExpectToBeDefined(apiKeyId);
|
|
|
|
const tokenResponse = await generateApiKeyToken({
|
|
apiKeyId,
|
|
accessToken: APPLE_JANE_ADMIN_ACCESS_TOKEN,
|
|
});
|
|
|
|
apiKeyToken = tokenResponse.body.data?.generateApiKeyToken?.token;
|
|
jestExpectToBeDefined(apiKeyToken);
|
|
};
|
|
|
|
beforeAll(async () => {
|
|
usageLimitRepository =
|
|
getCoreRepository<UsageLimitEntity>(UsageLimitEntity);
|
|
featureFlagRepository =
|
|
getCoreRepository<FeatureFlagEntity>(FeatureFlagEntity);
|
|
apiKeyRepository = getCoreRepository<ApiKeyEntity>(ApiKeyEntity);
|
|
redis = await createClient({ url: process.env.REDIS_URL }).connect();
|
|
|
|
await createDedicatedApiKey();
|
|
|
|
await featureFlagRepository.delete({
|
|
key: FeatureFlagKey.IS_API_RATE_LIMIT_V2_ENABLED,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
await featureFlagRepository.save({
|
|
key: FeatureFlagKey.IS_API_RATE_LIMIT_V2_ENABLED,
|
|
value: true,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
|
|
const [usageLimit] = await usageLimitRepository.save([
|
|
{
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
resourceType: UsageResourceType.API,
|
|
operationType: UsageOperationType.API_REQUEST,
|
|
spenderType: 'apiKey',
|
|
spenderId: apiKeyId,
|
|
limitKind: 'speed',
|
|
periodCount: WINDOW_SECONDS,
|
|
periodUnit: 'second',
|
|
meter: 'quantity',
|
|
limitValue: LIMIT_VALUE,
|
|
burstValue: LIMIT_VALUE,
|
|
},
|
|
]);
|
|
|
|
usageLimitId = usageLimit.id;
|
|
|
|
await invalidateWorkspaceCaches();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await usageLimitRepository.delete({ id: usageLimitId });
|
|
await featureFlagRepository.delete({
|
|
key: FeatureFlagKey.IS_API_RATE_LIMIT_V2_ENABLED,
|
|
workspaceId: SEED_APPLE_WORKSPACE_ID,
|
|
});
|
|
await apiKeyRepository.delete({ id: apiKeyId });
|
|
await invalidateWorkspaceCaches();
|
|
await redis.quit();
|
|
});
|
|
|
|
describe('over GraphQL', () => {
|
|
it('admits a request and rejects the one that follows it', async () => {
|
|
await waitForBucketRefill();
|
|
|
|
const admitted = await findCompaniesOverGraphql();
|
|
|
|
expect(admitted.body.errors).toBeUndefined();
|
|
|
|
const rejected = await findCompaniesOverGraphql();
|
|
|
|
expect(rejected.body.errors?.[0]?.extensions?.code).toBe('RATE_LIMITED');
|
|
});
|
|
|
|
// GraphQL keeps answering 200 and reports the denial in the extensions, so
|
|
// an Apollo caller reads it as a GraphQL error rather than a network one.
|
|
it('reports the denial in the body rather than in the HTTP status', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverGraphql();
|
|
|
|
const rejected = await findCompaniesOverGraphql();
|
|
|
|
expect(rejected.status).toBe(200);
|
|
expect(rejected.body.errors?.[0]?.extensions?.http).toBeUndefined();
|
|
});
|
|
|
|
it('names the exhausted scope and says when to retry', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverGraphql();
|
|
|
|
const { body } = await findCompaniesOverGraphql();
|
|
const extensions = body.errors?.[0]?.extensions;
|
|
|
|
expect(extensions).toMatchObject({
|
|
code: 'RATE_LIMITED',
|
|
limitKind: 'speed',
|
|
exhaustedKind: 'limit',
|
|
limit: LIMIT_VALUE,
|
|
remaining: 0,
|
|
periodCount: WINDOW_SECONDS,
|
|
periodUnit: 'second',
|
|
scope: { spenderType: 'apiKey', spenderId: apiKeyId },
|
|
});
|
|
expect(extensions.retryAfterMs).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('lets the caller back in once the window refills', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverGraphql();
|
|
await findCompaniesOverGraphql();
|
|
|
|
await waitForBucketRefill();
|
|
|
|
expect((await findCompaniesOverGraphql()).body.errors).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe('over REST', () => {
|
|
it('admits a request and rejects the one that follows it', async () => {
|
|
await waitForBucketRefill();
|
|
|
|
const admitted = await findCompaniesOverRest();
|
|
|
|
expect(admitted.status).toBe(200);
|
|
|
|
const rejected = await findCompaniesOverRest();
|
|
|
|
expect(rejected.status).toBe(429);
|
|
});
|
|
|
|
it('names the exhausted scope in the body', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverRest();
|
|
|
|
const { body } = await findCompaniesOverRest();
|
|
|
|
expect(body).toMatchObject({
|
|
statusCode: 429,
|
|
error: 'RATE_LIMITED',
|
|
limitKind: 'speed',
|
|
exhaustedKind: 'limit',
|
|
limit: LIMIT_VALUE,
|
|
remaining: 0,
|
|
periodCount: WINDOW_SECONDS,
|
|
periodUnit: 'second',
|
|
retryAfterSeconds: 1,
|
|
scope: { spenderType: 'apiKey', spenderId: apiKeyId },
|
|
});
|
|
expect(body.messages).toHaveLength(1);
|
|
});
|
|
|
|
it('answers with a Retry-After the caller can honour', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverRest();
|
|
|
|
const rejected = await findCompaniesOverRest();
|
|
|
|
expect(rejected.headers['retry-after']).toBe('1');
|
|
expect(rejected.headers['x-ratelimit-limit']).toBe(String(LIMIT_VALUE));
|
|
expect(rejected.headers['x-ratelimit-remaining']).toBe('0');
|
|
expect(Number(rejected.headers['x-ratelimit-reset'])).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('lets the caller back in once the window refills', async () => {
|
|
await waitForBucketRefill();
|
|
await findCompaniesOverRest();
|
|
await findCompaniesOverRest();
|
|
|
|
await waitForBucketRefill();
|
|
|
|
expect((await findCompaniesOverRest()).status).toBe(200);
|
|
});
|
|
});
|
|
});
|