Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
31 lines
1.4 KiB
Markdown
31 lines
1.4 KiB
Markdown
---
|
|
paths:
|
|
- "web/styles/**"
|
|
---
|
|
|
|
# Writing CSS
|
|
|
|
- Use `em` units instead of `px` for computed CSS values that need to
|
|
scale with font size. Pixel approximations break at different zoom
|
|
levels and font-size settings.
|
|
- **Review CSS for redundant rules.** After writing CSS, review the
|
|
full set of rules affecting the same elements. Look for rules that
|
|
are immediately overridden by a more specific selector, duplicated
|
|
selector lists, or cases where scoping (e.g., `:not()`) would
|
|
eliminate the need for an override.
|
|
- **Check CSS change scope.** When modifying CSS, always check what
|
|
other pages or components use the same selectors, files, and
|
|
classes. Use `git grep` on class names and check webpack bundle
|
|
entries to understand which pages load the file. Prefer scoped
|
|
overrides (e.g., `.parent .target`) over modifying shared rules,
|
|
to avoid unintended changes to other parts of the app.
|
|
- Use class or ID selectors, not bare tag selectors or attribute
|
|
selectors. If no suitable class exists, add one.
|
|
|
|
When removing a CSS dependency (e.g., Bootstrap), audit the full
|
|
property list of every rule, not just visually obvious properties like
|
|
colors and backgrounds. Subtle properties like `line-height`, `margin`,
|
|
`padding`, `text-decoration`, `font-weight`, and `border` are easy to
|
|
miss but cause visible regressions. Check inherited properties too —
|
|
e.g., a `body` rule's `line-height` or `margin` affects all descendants.
|