64898b2c79
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
25 lines
1.0 KiB
Markdown
25 lines
1.0 KiB
Markdown
---
|
|
name: self-review
|
|
description: "Zulip's self-review checklist. Use when you believe a branch is complete, before presenting the work or opening a PR."
|
|
---
|
|
|
|
# Self-Review Checklist
|
|
|
|
Before finalizing, verify:
|
|
|
|
- [ ] The PR addresses all points described in the issue
|
|
- [ ] All relevant tests pass locally
|
|
- [ ] Code follows existing patterns in the codebase
|
|
- [ ] Names (functions, variables, tests) are clear and greppable
|
|
- [ ] Commit messages, comments, and PR description are well done.
|
|
- [ ] Each commit is a minimal coherent idea
|
|
- [ ] No debugging code or unnecessary comments remain
|
|
- [ ] Type annotations are complete and correct
|
|
- [ ] User-facing strings are tagged for translation
|
|
- [ ] User-facing error messages are clear and actionable
|
|
- [ ] No secrets or credentials are hardcoded
|
|
- [ ] Documentation is updated if behavior changes
|
|
- [ ] Refactoring is complete (`git grep` for remaining occurrences)
|
|
- [ ] Security audit of changes. Always check for XSS in UI changes
|
|
and for incorrect access control in server changes.
|