64898b2c79
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
1649 lines
54 KiB
JavaScript
1649 lines
54 KiB
JavaScript
"use strict";
|
|
|
|
const assert = require("node:assert/strict");
|
|
|
|
const {make_realm} = require("./lib/example_realm.cjs");
|
|
const {make_user} = require("./lib/example_user.cjs");
|
|
const {mock_esm, set_global, zrequire} = require("./lib/namespace.cjs");
|
|
const {make_stub} = require("./lib/stub.cjs");
|
|
const {run_test, noop} = require("./lib/test.cjs");
|
|
const blueslip = require("./lib/zblueslip.cjs");
|
|
const {$} = require("./lib/zjquery.cjs");
|
|
const {page_params} = require("./lib/zpage_params.cjs");
|
|
|
|
const alice_user_id = 5;
|
|
|
|
const sample_message = {
|
|
id: 1001,
|
|
reactions: [
|
|
{emoji_name: "smile", user_id: 5, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
{emoji_name: "smile", user_id: 6, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
{emoji_name: "frown", user_id: 7, reaction_type: "unicode_emoji", emoji_code: "1f641"},
|
|
|
|
{emoji_name: "tada", user_id: 7, reaction_type: "unicode_emoji", emoji_code: "1f389"},
|
|
{emoji_name: "tada", user_id: 8, reaction_type: "unicode_emoji", emoji_code: "1f389"},
|
|
|
|
{emoji_name: "rocket", user_id: 5, reaction_type: "unicode_emoji", emoji_code: "1f680"},
|
|
{emoji_name: "rocket", user_id: 6, reaction_type: "unicode_emoji", emoji_code: "1f680"},
|
|
{emoji_name: "rocket", user_id: 7, reaction_type: "unicode_emoji", emoji_code: "1f680"},
|
|
|
|
{emoji_name: "wave", user_id: 6, reaction_type: "unicode_emoji", emoji_code: "1f44b"},
|
|
{emoji_name: "wave", user_id: 7, reaction_type: "unicode_emoji", emoji_code: "1f44b"},
|
|
{emoji_name: "wave", user_id: 8, reaction_type: "unicode_emoji", emoji_code: "1f44b"},
|
|
|
|
{
|
|
emoji_name: "inactive_realm_emoji",
|
|
user_id: 5,
|
|
reaction_type: "realm_emoji",
|
|
emoji_code: "992",
|
|
},
|
|
],
|
|
};
|
|
|
|
const channel = mock_esm("../src/channel");
|
|
const message_store = mock_esm("../src/message_store");
|
|
const settings_data = mock_esm("../src/settings_data");
|
|
const spectators = mock_esm("../src/spectators", {
|
|
login_to_access() {},
|
|
});
|
|
const message_lists = mock_esm("../src/message_lists", {
|
|
current: {
|
|
id: 1,
|
|
},
|
|
home: {
|
|
id: 2,
|
|
},
|
|
});
|
|
|
|
set_global("document", "document-stub");
|
|
|
|
const emoji = zrequire("emoji");
|
|
const emoji_codes = zrequire("../../static/generated/emoji/emoji_codes.json");
|
|
const people = zrequire("people");
|
|
const reactions = zrequire("reactions");
|
|
const retry_backoff = zrequire("retry_backoff");
|
|
const {set_current_user, set_realm} = zrequire("state_data");
|
|
const {initialize_user_settings} = zrequire("user_settings");
|
|
|
|
const current_user = {};
|
|
set_current_user(current_user);
|
|
set_realm(make_realm());
|
|
const user_settings = {};
|
|
initialize_user_settings({user_settings});
|
|
|
|
const emoji_params = {
|
|
realm_emoji: {
|
|
991: {
|
|
id: "991",
|
|
name: "realm_emoji",
|
|
source_url: "/url/for/991",
|
|
deactivated: false,
|
|
},
|
|
992: {
|
|
id: "992",
|
|
name: "inactive_realm_emoji",
|
|
source_url: "/url/for/992",
|
|
still_url: "/still/url/for/992",
|
|
deactivated: true,
|
|
},
|
|
},
|
|
emoji_codes,
|
|
};
|
|
|
|
emoji.initialize(emoji_params);
|
|
|
|
const alice = make_user({
|
|
email: "alice@example.com",
|
|
user_id: alice_user_id,
|
|
full_name: "Alice",
|
|
});
|
|
const bob = make_user({
|
|
email: "bob@example.com",
|
|
user_id: 6,
|
|
full_name: "Bob van Roberts",
|
|
});
|
|
const cali = make_user({
|
|
email: "cali@example.com",
|
|
user_id: 7,
|
|
full_name: "Cali",
|
|
});
|
|
const alexus = make_user({
|
|
email: "alexus@example.com",
|
|
user_id: 8,
|
|
full_name: "Alexus",
|
|
});
|
|
people.add_active_user(alice);
|
|
people.add_active_user(bob);
|
|
people.add_active_user(cali);
|
|
people.add_active_user(alexus);
|
|
|
|
function test(label, f) {
|
|
run_test(label, (helpers) => {
|
|
helpers.override(current_user, "user_id", alice_user_id);
|
|
f(helpers);
|
|
});
|
|
}
|
|
|
|
function sample_message_with_clean_reactions() {
|
|
const message = {...sample_message};
|
|
convert_reactions_to_clean_reactions(message);
|
|
return message;
|
|
}
|
|
|
|
function convert_reactions_to_clean_reactions(message) {
|
|
message.clean_reactions = reactions.generate_clean_reactions(message);
|
|
delete message.reactions;
|
|
}
|
|
|
|
test("basics", () => {
|
|
settings_data.user_can_access_all_other_users = () => true;
|
|
const message = sample_message_with_clean_reactions();
|
|
const result = reactions.get_message_reactions(message);
|
|
assert.ok(reactions.current_user_has_reacted_to_emoji(message, "unicode_emoji,1f604"));
|
|
assert.ok(!reactions.current_user_has_reacted_to_emoji(message, "bogus"));
|
|
|
|
result.sort((a, b) => a.count - b.count);
|
|
|
|
const expected_result = [
|
|
{
|
|
emoji_name: "frown",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f641",
|
|
local_id: "unicode_emoji,1f641",
|
|
count: 1,
|
|
vote_text: "1",
|
|
user_ids: [7],
|
|
label: "translated: Cali reacted with :frown:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "inactive_realm_emoji",
|
|
reaction_type: "realm_emoji",
|
|
emoji_code: "992",
|
|
local_id: "realm_emoji,992",
|
|
count: 1,
|
|
vote_text: "1",
|
|
user_ids: [5],
|
|
label: "translated: You (click to remove) reacted with :inactive_realm_emoji:",
|
|
emoji_alt_code: false,
|
|
is_realm_emoji: true,
|
|
url: "/url/for/992",
|
|
still_url: "/still/url/for/992",
|
|
class: "message_reaction reacted",
|
|
},
|
|
{
|
|
emoji_name: "smile",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f604",
|
|
local_id: "unicode_emoji,1f604",
|
|
count: 2,
|
|
vote_text: "2",
|
|
user_ids: [5, 6],
|
|
label: "translated: You (click to remove) and Bob van Roberts reacted with :smile:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction reacted",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "tada",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f389",
|
|
local_id: "unicode_emoji,1f389",
|
|
count: 2,
|
|
vote_text: "2",
|
|
user_ids: [7, 8],
|
|
label: "translated: Cali and Alexus reacted with :tada:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "rocket",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f680",
|
|
local_id: "unicode_emoji,1f680",
|
|
count: 3,
|
|
vote_text: "3",
|
|
user_ids: [5, 6, 7],
|
|
label: "translated: You (click to remove), Bob van Roberts and Cali reacted with :rocket:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction reacted",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "wave",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44b",
|
|
local_id: "unicode_emoji,1f44b",
|
|
count: 3,
|
|
vote_text: "3",
|
|
user_ids: [6, 7, 8],
|
|
label: "translated: Bob van Roberts, Cali and Alexus reacted with :wave:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction",
|
|
is_realm_emoji: false,
|
|
},
|
|
];
|
|
assert.deepEqual(result, expected_result);
|
|
});
|
|
|
|
test("reactions from unknown users", () => {
|
|
settings_data.user_can_access_all_other_users = () => false;
|
|
people.add_inaccessible_user(10);
|
|
const message = {
|
|
id: 1001,
|
|
reactions: [
|
|
{emoji_name: "smile", user_id: 5, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
{emoji_name: "smile", user_id: 9, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
{emoji_name: "frown", user_id: 9, reaction_type: "unicode_emoji", emoji_code: "1f641"},
|
|
|
|
{emoji_name: "tada", user_id: 6, reaction_type: "unicode_emoji", emoji_code: "1f389"},
|
|
{emoji_name: "tada", user_id: 10, reaction_type: "unicode_emoji", emoji_code: "1f389"},
|
|
],
|
|
};
|
|
|
|
convert_reactions_to_clean_reactions(message);
|
|
const result = reactions.get_message_reactions(message);
|
|
result.sort((a, b) => a.count - b.count);
|
|
|
|
const expected_result = [
|
|
{
|
|
emoji_name: "frown",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f641",
|
|
local_id: "unicode_emoji,1f641",
|
|
count: 1,
|
|
vote_text: "1",
|
|
user_ids: [9],
|
|
label: "translated: translated: Unknown user reacted with :frown:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "smile",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f604",
|
|
local_id: "unicode_emoji,1f604",
|
|
count: 2,
|
|
vote_text: "2",
|
|
user_ids: [5, 9],
|
|
label: "translated: You (click to remove) and translated: Unknown user reacted with :smile:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction reacted",
|
|
is_realm_emoji: false,
|
|
},
|
|
{
|
|
emoji_name: "tada",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f389",
|
|
local_id: "unicode_emoji,1f389",
|
|
count: 2,
|
|
vote_text: "2",
|
|
user_ids: [6, 10],
|
|
label: "translated: Bob van Roberts and translated: Unknown user reacted with :tada:",
|
|
emoji_alt_code: false,
|
|
class: "message_reaction",
|
|
is_realm_emoji: false,
|
|
},
|
|
];
|
|
assert.deepEqual(result, expected_result);
|
|
});
|
|
|
|
test("unknown realm emojis (add)", () => {
|
|
assert.throws(
|
|
() =>
|
|
reactions.insert_new_reaction(
|
|
{
|
|
reaction_type: "realm_emoji",
|
|
emoji_name: "false_emoji",
|
|
emoji_code: "broken",
|
|
},
|
|
1000,
|
|
alice.user_id,
|
|
),
|
|
{
|
|
name: "Error",
|
|
message: "Cannot find realm emoji for code 'broken'.",
|
|
},
|
|
);
|
|
});
|
|
|
|
test("unknown realm emojis (insert)", () => {
|
|
assert.throws(
|
|
() =>
|
|
reactions.insert_new_reaction(
|
|
{
|
|
reaction_type: "realm_emoji",
|
|
emoji_name: "fake_emoji",
|
|
emoji_code: "bogus",
|
|
},
|
|
1000,
|
|
bob.user_id,
|
|
),
|
|
{
|
|
name: "Error",
|
|
message: "Cannot find realm emoji for code 'bogus'.",
|
|
},
|
|
);
|
|
});
|
|
|
|
test("sending", ({override, override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
assert.equal(message.id, 1001);
|
|
override(message_store, "get", (message_id) => {
|
|
assert.equal(message_id, message.id);
|
|
return message;
|
|
});
|
|
|
|
let emoji_name = "smile"; // should be a current reaction
|
|
|
|
override_rewire(reactions, "add_reaction", noop);
|
|
override_rewire(reactions, "remove_reaction", noop);
|
|
|
|
{
|
|
const stub = make_stub();
|
|
channel.del = stub.f;
|
|
reactions.toggle_emoji_reaction(message, emoji_name);
|
|
assert.equal(stub.num_calls, 1);
|
|
const args = stub.get_args("args").args;
|
|
assert.equal(args.url, "/json/messages/1001/reactions");
|
|
assert.deepEqual(args.data, {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "smile",
|
|
emoji_code: "1f604",
|
|
});
|
|
// args.success() does nothing; just make sure it doesn't crash
|
|
args.success();
|
|
|
|
// similarly, we only exercise the failure codepath
|
|
blueslip.expect("error", "Error sending reaction");
|
|
args.error({readyState: 4, status: 400, responseJSON: {msg: "Some error message"}});
|
|
}
|
|
emoji_name = "alien"; // not set yet
|
|
{
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
reactions.toggle_emoji_reaction(message, emoji_name);
|
|
assert.equal(stub.num_calls, 1);
|
|
const args = stub.get_args("args").args;
|
|
assert.equal(args.url, "/json/messages/1001/reactions");
|
|
assert.deepEqual(args.data, {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "alien",
|
|
emoji_code: "1f47d",
|
|
});
|
|
}
|
|
|
|
emoji_name = "inactive_realm_emoji";
|
|
{
|
|
// Test removing a deactivated realm emoji. A user can interact with a
|
|
// deactivated realm emoji only by clicking on a reaction, hence, only
|
|
// `process_reaction_click()` codepath supports deleting/adding a deactivated
|
|
// realm emoji.
|
|
const stub = make_stub();
|
|
channel.del = stub.f;
|
|
reactions.process_reaction_click(message.id, "realm_emoji,992");
|
|
assert.equal(stub.num_calls, 1);
|
|
const args = stub.get_args("args").args;
|
|
assert.equal(args.url, "/json/messages/1001/reactions");
|
|
assert.deepEqual(args.data, {
|
|
reaction_type: "realm_emoji",
|
|
emoji_name: "inactive_realm_emoji",
|
|
emoji_code: "992",
|
|
});
|
|
}
|
|
|
|
emoji_name = "zulip"; // Test adding zulip emoji.
|
|
{
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
reactions.toggle_emoji_reaction(message, emoji_name);
|
|
assert.equal(stub.num_calls, 1);
|
|
const args = stub.get_args("args").args;
|
|
assert.equal(args.url, "/json/messages/1001/reactions");
|
|
assert.deepEqual(args.data, {
|
|
reaction_type: "zulip_extra_emoji",
|
|
emoji_name: "zulip",
|
|
emoji_code: "zulip",
|
|
still_url: null,
|
|
url: "/static/generated/emoji/images/emoji/unicode/zulip.png",
|
|
});
|
|
}
|
|
|
|
emoji_name = "unknown-emoji"; // Test sending an emoji unknown to frontend.
|
|
assert.throws(() => reactions.toggle_emoji_reaction(message, emoji_name), {
|
|
name: "Error",
|
|
message: "Bad emoji name: unknown-emoji",
|
|
});
|
|
});
|
|
|
|
test("sending precondition failures", ({override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
override_rewire(reactions, "add_reaction", noop);
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
|
|
reactions.toggle_emoji_reaction(message, "octopus");
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
// A precondition failure isn't reported (no blueslip.expect here)
|
|
// because the user already got what they wanted.
|
|
stub.get_args("args").args.error({
|
|
readyState: 4,
|
|
status: 400,
|
|
responseJSON: {code: "REACTION_ALREADY_EXISTS", msg: "Reaction already exists."},
|
|
});
|
|
|
|
// The request is no longer in flight, so the user can send another one.
|
|
reactions.toggle_emoji_reaction(message, "octopus");
|
|
assert.equal(stub.num_calls, 2);
|
|
|
|
// A cancelled request isn't reported either.
|
|
stub.get_args("args").args.error({readyState: 0, status: 0});
|
|
reactions.toggle_emoji_reaction(message, "octopus");
|
|
assert.equal(stub.num_calls, 3);
|
|
stub.get_args("args").args.success();
|
|
});
|
|
|
|
test("sending failure retries", ({override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
override_rewire(reactions, "add_reaction", noop);
|
|
override_rewire(reactions, "remove_reaction", noop);
|
|
override_rewire(retry_backoff, "get_retry_backoff_seconds", () => 10);
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
|
|
let timeout_callback;
|
|
let timeout_delay_ms;
|
|
set_global("setTimeout", (f, delay) => {
|
|
timeout_callback = f;
|
|
timeout_delay_ms = delay;
|
|
});
|
|
|
|
reactions.toggle_emoji_reaction(message, "airplane");
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
// A rate-limited request is retried after the server-specified delay,
|
|
// without reporting an error.
|
|
stub.get_args("args").args.error({
|
|
readyState: 4,
|
|
status: 429,
|
|
responseJSON: {code: "RATE_LIMIT_HIT", "retry-after": 60},
|
|
});
|
|
assert.equal(timeout_delay_ms, 60 * 1000);
|
|
|
|
// Clicking again while a retry is pending doesn't send a duplicate
|
|
// request.
|
|
reactions.toggle_emoji_reaction(message, "airplane");
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
timeout_callback();
|
|
assert.equal(stub.num_calls, 2);
|
|
|
|
// Transient server errors are retried with backoff, and reported only
|
|
// once we give up.
|
|
for (let attempt = 0; attempt < 5; attempt += 1) {
|
|
stub.get_args("args").args.error({
|
|
readyState: 4,
|
|
status: 502,
|
|
responseText: "Bad gateway",
|
|
});
|
|
assert.equal(timeout_delay_ms, 10 * 1000);
|
|
timeout_callback();
|
|
assert.equal(stub.num_calls, 3 + attempt);
|
|
}
|
|
blueslip.expect("error", "Error sending reaction after retries");
|
|
stub.get_args("args").args.error({readyState: 4, status: 502, responseText: "Bad gateway"});
|
|
|
|
// The request is no longer in flight, so the user can try again.
|
|
reactions.toggle_emoji_reaction(message, "airplane");
|
|
assert.equal(stub.num_calls, 8);
|
|
stub.get_args("args").args.success();
|
|
});
|
|
|
|
test("sending failure reverts optimistic update", ({override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
|
|
const add_stub = make_stub();
|
|
const remove_stub = make_stub();
|
|
override_rewire(reactions, "add_reaction", add_stub.f);
|
|
override_rewire(reactions, "remove_reaction", remove_stub.f);
|
|
|
|
blueslip.expect("error", "Error sending reaction", 2);
|
|
|
|
{
|
|
// A failed add is reverted by removing the reaction locally.
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
reactions.toggle_emoji_reaction(message, "banana");
|
|
assert.equal(add_stub.num_calls, 1);
|
|
|
|
stub.get_args("args").args.error({
|
|
readyState: 4,
|
|
status: 400,
|
|
responseJSON: {msg: "Invalid message(s)"},
|
|
});
|
|
assert.equal(remove_stub.num_calls, 1);
|
|
assert.deepEqual(remove_stub.get_args("event").event, {
|
|
message_id: message.id,
|
|
user_id: alice_user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "banana",
|
|
emoji_code: "1f34c",
|
|
});
|
|
}
|
|
|
|
{
|
|
// A failed remove is reverted by re-adding the reaction locally.
|
|
const stub = make_stub();
|
|
channel.del = stub.f;
|
|
reactions.toggle_emoji_reaction(message, "smile");
|
|
assert.equal(remove_stub.num_calls, 2);
|
|
|
|
stub.get_args("args").args.error({
|
|
readyState: 4,
|
|
status: 400,
|
|
responseJSON: {msg: "Invalid message(s)"},
|
|
});
|
|
assert.equal(add_stub.num_calls, 2);
|
|
assert.deepEqual(add_stub.get_args("event").event, {
|
|
message_id: message.id,
|
|
user_id: alice_user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "smile",
|
|
emoji_code: "1f604",
|
|
});
|
|
}
|
|
});
|
|
|
|
test("prevent_simultaneous_requests_updating_reaction", ({override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
override_rewire(reactions, "add_reaction", noop);
|
|
const stub = make_stub();
|
|
channel.post = stub.f;
|
|
|
|
// Verify that two requests to add the same reaction in a row only
|
|
// result in a single request to the server.
|
|
reactions.toggle_emoji_reaction(message, "cow");
|
|
reactions.toggle_emoji_reaction(message, "cow");
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
});
|
|
|
|
function stub_reactions(message_id) {
|
|
const $message_reactions = $.create("reactions-stub");
|
|
const $message_row = $.create(`#message-row-1-${CSS.escape(message_id)}`);
|
|
message_lists.all_rendered_row_for_message_id = () => $message_row;
|
|
$message_row.set_find_results(".message_reactions", $message_reactions);
|
|
return $message_reactions;
|
|
}
|
|
|
|
function stub_reaction(message_id, local_id) {
|
|
const $reaction = $.create("reaction-stub");
|
|
stub_reactions(message_id).set_find_results(
|
|
`[data-reaction-id='${CSS.escape(local_id)}']`,
|
|
$reaction,
|
|
);
|
|
return $reaction;
|
|
}
|
|
|
|
test("get_vote_text (more than 3 reactions)", ({override}) => {
|
|
const user_ids = [5, 6, 7];
|
|
const message = {...sample_message};
|
|
|
|
override(user_settings, "display_emoji_reaction_users", true);
|
|
assert.equal(
|
|
"translated: You, Bob van Roberts, Cali",
|
|
reactions.get_vote_text(user_ids, message),
|
|
);
|
|
});
|
|
|
|
test("get_vote_text (3 reactions)", ({override}) => {
|
|
const user_ids = [5, 6, 7];
|
|
const message = {...sample_message};
|
|
|
|
// slicing the reactions array to only include first 3 reactions
|
|
message.reactions = message.reactions.slice(0, 3);
|
|
|
|
override(user_settings, "display_emoji_reaction_users", true);
|
|
assert.equal(
|
|
"translated: You, Bob van Roberts, Cali",
|
|
reactions.get_vote_text(user_ids, message),
|
|
);
|
|
});
|
|
|
|
test("update_vote_text_on_message", ({override, override_rewire}) => {
|
|
// the vote_text in this message is intentionally wrong.
|
|
// After calling update_vote_text_on_message(), we
|
|
// will check if the vote_text has been correctly updated.
|
|
const message = {
|
|
id: 1001,
|
|
reactions: [
|
|
{
|
|
emoji_name: "wave",
|
|
user_id: 5,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44b",
|
|
vote_text: "2",
|
|
},
|
|
{
|
|
emoji_name: "wave",
|
|
user_id: 6,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44b",
|
|
vote_text: "2",
|
|
},
|
|
|
|
{
|
|
emoji_name: "inactive_realm_emoji",
|
|
user_id: 5,
|
|
reaction_type: "realm_emoji",
|
|
emoji_code: "992",
|
|
vote_text: "1",
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
|
|
override(user_settings, "display_emoji_reaction_users", true);
|
|
|
|
override_rewire(reactions, "find_reaction", noop);
|
|
override_rewire(reactions, "set_reaction_vote_text", noop);
|
|
|
|
reactions.update_vote_text_on_message(message);
|
|
|
|
const updated_message = {
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"realm_emoji,992": {
|
|
class: "message_reaction reacted",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "992",
|
|
emoji_name: "inactive_realm_emoji",
|
|
is_realm_emoji: true,
|
|
label: "translated: You (click to remove) reacted with :inactive_realm_emoji:",
|
|
local_id: "realm_emoji,992",
|
|
reaction_type: "realm_emoji",
|
|
still_url: "/still/url/for/992",
|
|
url: "/url/for/992",
|
|
user_ids: [5],
|
|
vote_text: "translated: You",
|
|
},
|
|
"unicode_emoji,1f44b": {
|
|
class: "message_reaction reacted",
|
|
count: 2,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f44b",
|
|
emoji_name: "wave",
|
|
is_realm_emoji: false,
|
|
label: "translated: You (click to remove) and Bob van Roberts reacted with :wave:",
|
|
local_id: "unicode_emoji,1f44b",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [5, 6],
|
|
vote_text: "translated: You, Bob van Roberts",
|
|
},
|
|
}),
|
|
),
|
|
id: 1001,
|
|
};
|
|
// message.reactions is deleted too.
|
|
assert.deepEqual(message, updated_message);
|
|
});
|
|
|
|
test("update_user_full_name", ({override, override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
override(message_lists, "all_rendered_message_lists", () => [{all_messages: () => [message]}]);
|
|
|
|
let updated_messages = [];
|
|
override_rewire(reactions, "update_vote_text_on_message", (msg) => {
|
|
updated_messages.push(msg.id);
|
|
});
|
|
|
|
// alice_user_id (5) is in reactions — should trigger update.
|
|
reactions.update_user_full_name(alice_user_id);
|
|
assert.deepEqual(updated_messages, [1001]);
|
|
|
|
// User 999 has no reactions — should not trigger update.
|
|
updated_messages = [];
|
|
reactions.update_user_full_name(999);
|
|
assert.deepEqual(updated_messages, []);
|
|
});
|
|
|
|
test("find_reaction", () => {
|
|
const message_id = 99;
|
|
const local_id = "unicode_emoji,1f44b";
|
|
const $reaction = stub_reaction(message_id, local_id);
|
|
|
|
assert.equal(reactions.find_reaction(message_id, local_id)[0], $reaction[0]);
|
|
});
|
|
|
|
test("get_reaction_sections", () => {
|
|
const $message_reactions = stub_reactions(555);
|
|
|
|
const $section = reactions.get_reaction_sections(555);
|
|
|
|
assert.equal($section[0], $message_reactions[0]);
|
|
});
|
|
|
|
test("emoji_reaction_title", ({override}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
override(message_store, "get", () => message);
|
|
const local_id = "unicode_emoji,1f604";
|
|
|
|
assert.equal(
|
|
reactions.get_reaction_title_data(message.id, local_id),
|
|
"translated: You (click to remove) and Bob van Roberts reacted with :smile:",
|
|
);
|
|
});
|
|
|
|
test("add_reaction/remove_reaction", ({override, override_rewire}) => {
|
|
const message = {
|
|
id: 2001,
|
|
reactions: [],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
|
|
override(user_settings, "display_emoji_reaction_users", true);
|
|
|
|
override(message_store, "get", () => message);
|
|
|
|
let function_calls = [];
|
|
|
|
override_rewire(reactions, "insert_new_reaction", (clean_reaction_object, message, user_id) => {
|
|
function_calls.push({
|
|
name: "insert_new_reaction",
|
|
clean_reaction_object,
|
|
message,
|
|
user_id,
|
|
});
|
|
});
|
|
override_rewire(
|
|
reactions,
|
|
"update_existing_reaction",
|
|
(clean_reaction_object, message, user_id) => {
|
|
function_calls.push({
|
|
name: "update_existing_reaction",
|
|
clean_reaction_object,
|
|
message,
|
|
user_id,
|
|
});
|
|
},
|
|
);
|
|
override_rewire(
|
|
reactions,
|
|
"remove_reaction_from_view",
|
|
(clean_reaction_object, message, user_id) => {
|
|
function_calls.push({
|
|
name: "remove_reaction_from_view",
|
|
clean_reaction_object,
|
|
message,
|
|
user_id,
|
|
});
|
|
},
|
|
);
|
|
|
|
function test_function_calls(test_params) {
|
|
function_calls = [];
|
|
|
|
test_params.run_code();
|
|
|
|
assert.deepEqual(function_calls, test_params.expected_function_calls);
|
|
assert.deepEqual(
|
|
new Set(reactions.get_emojis_used_by_user_for_message_id(message.message_id)),
|
|
new Set(test_params.alice_emojis),
|
|
);
|
|
}
|
|
|
|
const alice_8ball_event = {
|
|
message_id: 2001,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "8ball",
|
|
emoji_code: "1f3b1",
|
|
user_id: alice.user_id,
|
|
};
|
|
|
|
const bob_8ball_event = {
|
|
message_id: 2001,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "8ball",
|
|
emoji_code: "1f3b1",
|
|
user_id: bob.user_id,
|
|
};
|
|
|
|
const cali_airplane_event = {
|
|
message_id: 2001,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "airplane",
|
|
emoji_code: "2708",
|
|
user_id: cali.user_id,
|
|
};
|
|
|
|
const clean_reaction_object_alice = {
|
|
class: "message_reaction reacted",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: alice_8ball_event.emoji_code,
|
|
emoji_name: alice_8ball_event.emoji_name,
|
|
is_realm_emoji: false,
|
|
label: "translated: You (click to remove) reacted with :8ball:",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: alice_8ball_event.reaction_type,
|
|
user_ids: [alice.user_id],
|
|
vote_text: "translated: You",
|
|
};
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.add_reaction(alice_8ball_event);
|
|
},
|
|
expected_function_calls: [
|
|
{
|
|
name: "insert_new_reaction",
|
|
clean_reaction_object: clean_reaction_object_alice,
|
|
message: {
|
|
id: alice_8ball_event.message_id,
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"unicode_emoji,1f3b1": clean_reaction_object_alice,
|
|
}),
|
|
),
|
|
},
|
|
user_id: alice_8ball_event.user_id,
|
|
},
|
|
],
|
|
alice_emojis: ["8ball"],
|
|
});
|
|
|
|
// Add redundant reaction.
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.add_reaction(alice_8ball_event);
|
|
},
|
|
expected_function_calls: [],
|
|
alice_emojis: ["8ball"],
|
|
});
|
|
|
|
const clean_reaction_object_bob = {
|
|
class: "message_reaction reacted",
|
|
count: 2,
|
|
emoji_alt_code: false,
|
|
emoji_code: bob_8ball_event.emoji_code,
|
|
emoji_name: bob_8ball_event.emoji_name,
|
|
is_realm_emoji: false,
|
|
label: "translated: You (click to remove) and Bob van Roberts reacted with :8ball:",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: bob_8ball_event.reaction_type,
|
|
user_ids: [alice.user_id, bob.user_id],
|
|
vote_text: "translated: You, Bob van Roberts",
|
|
};
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.add_reaction(bob_8ball_event);
|
|
},
|
|
expected_function_calls: [
|
|
{
|
|
name: "update_existing_reaction",
|
|
clean_reaction_object: clean_reaction_object_bob,
|
|
message: {
|
|
id: bob_8ball_event.message_id,
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"unicode_emoji,1f3b1": clean_reaction_object_bob,
|
|
}),
|
|
),
|
|
},
|
|
user_id: bob_8ball_event.user_id,
|
|
},
|
|
],
|
|
alice_emojis: ["8ball"],
|
|
});
|
|
|
|
const clean_reaction_object_cali = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: cali_airplane_event.emoji_code,
|
|
emoji_name: cali_airplane_event.emoji_name,
|
|
is_realm_emoji: false,
|
|
label: "translated: Cali reacted with :airplane:",
|
|
local_id: "unicode_emoji,2708",
|
|
reaction_type: cali_airplane_event.reaction_type,
|
|
user_ids: [cali.user_id],
|
|
vote_text: "Cali",
|
|
};
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.add_reaction(cali_airplane_event);
|
|
},
|
|
expected_function_calls: [
|
|
{
|
|
name: "insert_new_reaction",
|
|
clean_reaction_object: clean_reaction_object_cali,
|
|
message: {
|
|
id: cali_airplane_event.message_id,
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"unicode_emoji,1f3b1": clean_reaction_object_bob,
|
|
"unicode_emoji,2708": clean_reaction_object_cali,
|
|
}),
|
|
),
|
|
},
|
|
user_id: cali_airplane_event.user_id,
|
|
},
|
|
],
|
|
alice_emojis: ["8ball"],
|
|
});
|
|
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.remove_reaction(bob_8ball_event);
|
|
},
|
|
expected_function_calls: [
|
|
{
|
|
name: "remove_reaction_from_view",
|
|
clean_reaction_object: clean_reaction_object_alice,
|
|
message: {
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"unicode_emoji,1f3b1": clean_reaction_object_alice,
|
|
"unicode_emoji,2708": clean_reaction_object_cali,
|
|
}),
|
|
),
|
|
id: bob_8ball_event.message_id,
|
|
},
|
|
user_id: bob_8ball_event.user_id,
|
|
},
|
|
],
|
|
alice_emojis: ["8ball"],
|
|
});
|
|
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.remove_reaction(alice_8ball_event);
|
|
},
|
|
expected_function_calls: [
|
|
{
|
|
name: "remove_reaction_from_view",
|
|
clean_reaction_object: {
|
|
count: 0,
|
|
class: "message_reaction",
|
|
emoji_alt_code: false,
|
|
emoji_code: alice_8ball_event.emoji_code,
|
|
emoji_name: alice_8ball_event.emoji_name,
|
|
is_realm_emoji: false,
|
|
label: "translated: and reacted with :8ball:",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: alice_8ball_event.reaction_type,
|
|
user_ids: [],
|
|
vote_text: "",
|
|
},
|
|
message: {
|
|
clean_reactions: new Map(
|
|
Object.entries({
|
|
"unicode_emoji,2708": clean_reaction_object_cali,
|
|
}),
|
|
),
|
|
id: alice_8ball_event.message_id,
|
|
},
|
|
user_id: alice_8ball_event.user_id,
|
|
},
|
|
],
|
|
alice_emojis: [],
|
|
});
|
|
|
|
// Test redundant remove.
|
|
test_function_calls({
|
|
run_code() {
|
|
reactions.remove_reaction(alice_8ball_event);
|
|
},
|
|
expected_function_calls: [],
|
|
alice_emojis: [],
|
|
});
|
|
});
|
|
|
|
test("insert_new_reaction (first reaction)", ({mock_template, override_rewire}) => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
label: "translated: You (click to remove) reacted with :8ball:",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [alice.user_id],
|
|
};
|
|
const message_id = 501;
|
|
|
|
mock_template("message_reactions.hbs", false, (data) => {
|
|
assert.deepEqual(data, {
|
|
msg: {
|
|
message_reactions: [
|
|
{
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_name: "8ball",
|
|
emoji_code: "1f3b1",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
class: "message_reaction reacted",
|
|
message_id,
|
|
label: "translated: You (click to remove) reacted with :8ball:",
|
|
reaction_type: clean_reaction_object.reaction_type,
|
|
is_realm_emoji: false,
|
|
vote_text: "",
|
|
},
|
|
],
|
|
},
|
|
});
|
|
return "<msg-reactions-section-stub>";
|
|
});
|
|
|
|
const $rows = $.create("rows-stub");
|
|
message_lists.all_rendered_row_for_message_id = () => $rows;
|
|
|
|
const $messagebox_content = $.create("messagebox-content-stub");
|
|
$rows.set_find_results(".messagebox-content", $messagebox_content);
|
|
|
|
let append_called = false;
|
|
$messagebox_content[0].append = (element) => {
|
|
assert.equal(element.innerHTML, "<msg-reactions-section-stub>");
|
|
append_called = true;
|
|
};
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_name: "8ball",
|
|
user_id: alice.user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f3b1",
|
|
},
|
|
],
|
|
};
|
|
|
|
override_rewire(reactions, "update_vote_text_on_message", noop);
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.insert_new_reaction(clean_reaction_object, message, alice.user_id);
|
|
assert.ok(append_called);
|
|
});
|
|
|
|
test("insert_new_reaction (me w/unicode emoji)", ({mock_template}) => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
label: "translated: You (click to remove) reacted with :8ball:",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [alice.user_id],
|
|
};
|
|
const message_id = 501;
|
|
|
|
const $message_reactions = stub_reactions(message_id);
|
|
const $reaction_button = $.create("reaction-button-stub");
|
|
$message_reactions.set_find_results(".reaction_button", $reaction_button);
|
|
const $message_reactions_count = $.create("message-reaction-count-stub");
|
|
const $reaction = $.create("reaction-stub");
|
|
$reaction.set_find_results(".message_reaction_count", $message_reactions_count);
|
|
$message_reactions.set_find_results(
|
|
`[data-reaction-id='${CSS.escape("unicode_emoji,1f44d")}']`,
|
|
$reaction,
|
|
);
|
|
$message_reactions.set_find_results(
|
|
`[data-reaction-id='${CSS.escape("unicode_emoji,1f3b1")}']`,
|
|
$reaction,
|
|
);
|
|
|
|
mock_template("message_reaction.hbs", false, (data) => {
|
|
assert.deepEqual(data, {
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_name: "8ball",
|
|
emoji_code: "1f3b1",
|
|
local_id: "unicode_emoji,1f3b1",
|
|
class: "message_reaction reacted",
|
|
message_id,
|
|
label: "translated: You (click to remove) reacted with :8ball:",
|
|
reaction_type: clean_reaction_object.reaction_type,
|
|
is_realm_emoji: false,
|
|
vote_text: "",
|
|
});
|
|
return "<new-reaction-stub>";
|
|
});
|
|
|
|
let insert_called;
|
|
$reaction_button[0].before = (element) => {
|
|
assert.equal(element.innerHTML, "<new-reaction-stub>");
|
|
insert_called = true;
|
|
};
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_name: "+1",
|
|
user_id: bob.user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44d",
|
|
},
|
|
{
|
|
emoji_name: "8ball",
|
|
user_id: alice.user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f3b1",
|
|
},
|
|
],
|
|
};
|
|
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.insert_new_reaction(clean_reaction_object, message, alice.user_id);
|
|
assert.ok(insert_called);
|
|
});
|
|
|
|
test("insert_new_reaction (them w/zulip emoji)", ({mock_template}) => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "zulip",
|
|
emoji_name: "zulip",
|
|
is_realm_emoji: false,
|
|
label: "translated: Bob van Roberts reacted with :zulip:",
|
|
local_id: "realm_emoji,zulip",
|
|
reaction_type: "realm_emoji",
|
|
user_ids: [bob.user_id],
|
|
};
|
|
const message_id = 501;
|
|
|
|
const $message_reactions = stub_reactions(message_id);
|
|
const $reaction_button = $.create("reaction-button-stub");
|
|
$message_reactions.set_find_results(".reaction_button", $reaction_button);
|
|
const $message_reactions_count = $.create("message-reaction-count-stub");
|
|
const $reaction = $.create("reaction-stub");
|
|
$reaction.set_find_results(".message_reaction_count", $message_reactions_count);
|
|
$message_reactions.set_find_results(
|
|
`[data-reaction-id='${CSS.escape("unicode_emoji,1f44d")}']`,
|
|
$reaction,
|
|
);
|
|
$message_reactions.set_find_results(
|
|
`[data-reaction-id='${CSS.escape("unicode_emoji,1f3b1")}']`,
|
|
$reaction,
|
|
);
|
|
|
|
mock_template("message_reaction.hbs", false, (data) => {
|
|
assert.deepEqual(data, {
|
|
count: 1,
|
|
url: "/static/generated/emoji/images/emoji/unicode/zulip.png",
|
|
is_realm_emoji: true,
|
|
emoji_alt_code: false,
|
|
emoji_name: "zulip",
|
|
emoji_code: "zulip",
|
|
local_id: "realm_emoji,zulip",
|
|
class: "message_reaction",
|
|
message_id,
|
|
label: "translated: Bob van Roberts reacted with :zulip:",
|
|
still_url: null,
|
|
reaction_type: clean_reaction_object.reaction_type,
|
|
vote_text: "",
|
|
});
|
|
return "<new-reaction-stub>";
|
|
});
|
|
|
|
let insert_called;
|
|
$reaction_button[0].before = (element) => {
|
|
assert.equal(element.innerHTML, "<new-reaction-stub>");
|
|
insert_called = true;
|
|
};
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_name: "+1",
|
|
user_id: bob.user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44d",
|
|
},
|
|
{
|
|
emoji_name: "8ball",
|
|
user_id: bob.user_id,
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f3b1",
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.insert_new_reaction(clean_reaction_object, message, bob.user_id);
|
|
assert.ok(insert_called);
|
|
});
|
|
|
|
test("update_existing_reaction (me)", () => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 2,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [alice.user_id, bob.user_id],
|
|
};
|
|
const message_id = 503;
|
|
|
|
const $our_reaction = stub_reaction(message_id, "unicode_emoji,1f3b1");
|
|
const $reaction_count = $.create("reaction-count-stub");
|
|
$our_reaction.set_find_results(".message_reaction_count", $reaction_count);
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: alice.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: bob.user_id,
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.update_existing_reaction(clean_reaction_object, message, alice.user_id);
|
|
|
|
assert.ok($our_reaction.hasClass("reacted"));
|
|
assert.equal(
|
|
$our_reaction.attr("aria-label"),
|
|
"translated: You (click to remove) and Bob van Roberts reacted with :8ball:",
|
|
);
|
|
});
|
|
|
|
test("update_existing_reaction (them)", () => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 4,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [alice.user_id, bob.user_id, cali.user_id, alexus.user_id],
|
|
};
|
|
const message_id = 504;
|
|
|
|
const $our_reaction = stub_reaction(message_id, "unicode_emoji,1f3b1");
|
|
const $reaction_count = $.create("reaction-count-stub");
|
|
$our_reaction.set_find_results(".message_reaction_count", $reaction_count);
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: alice.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: bob.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: cali.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: alexus.user_id,
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
|
|
reactions.update_existing_reaction(clean_reaction_object, message, alexus.user_id);
|
|
|
|
assert.ok(!$our_reaction.hasClass("reacted"));
|
|
assert.equal(
|
|
$our_reaction.attr("aria-label"),
|
|
"translated: You (click to remove), Bob van Roberts, Cali and Alexus reacted with :8ball:",
|
|
);
|
|
});
|
|
|
|
test("remove_reaction_from_view (me)", () => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 2,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [bob.user_id, cali.user_id],
|
|
};
|
|
const message_id = 505;
|
|
|
|
const $message_reactions = stub_reaction(message_id, "unicode_emoji,1f3b1");
|
|
$message_reactions.addClass("reacted");
|
|
const $message_reactions_count = $.create("message-reaction-count-stub");
|
|
$message_reactions.set_find_results(".message_reaction_count", $message_reactions_count);
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: bob.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: cali.user_id,
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
|
|
reactions.remove_reaction_from_view(clean_reaction_object, message, alice.user_id);
|
|
|
|
assert.ok(!$message_reactions.hasClass("reacted"));
|
|
assert.equal(
|
|
$message_reactions.attr("aria-label"),
|
|
"translated: Bob van Roberts and Cali reacted with :8ball:",
|
|
);
|
|
});
|
|
|
|
test("remove_reaction_from_view (them)", () => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [alice.user_id],
|
|
};
|
|
const message_id = 506;
|
|
|
|
const $message_reactions = stub_reaction(message_id, "unicode_emoji,1f3b1");
|
|
$message_reactions.addClass("reacted");
|
|
const $message_reactions_count = $.create("message-reaction-count-stub");
|
|
$message_reactions.set_find_results(".message_reaction_count", $message_reactions_count);
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: alice.user_id,
|
|
},
|
|
],
|
|
};
|
|
convert_reactions_to_clean_reactions(message);
|
|
|
|
reactions.remove_reaction_from_view(clean_reaction_object, message, bob.user_id);
|
|
|
|
assert.ok($message_reactions.hasClass("reacted"));
|
|
assert.equal(
|
|
$message_reactions.attr("aria-label"),
|
|
"translated: You (click to remove) reacted with :8ball:",
|
|
);
|
|
});
|
|
|
|
test("remove_reaction_from_view (last person to react)", ({override_rewire}) => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [],
|
|
};
|
|
const message_id = 507;
|
|
|
|
const $reaction_container = $.create("stub-reaction-container");
|
|
$reaction_container.set_matches(".message_reaction_container", true);
|
|
|
|
const $our_reaction = stub_reaction(message_id, "unicode_emoji,1f3b1");
|
|
$our_reaction.set_parent($reaction_container);
|
|
|
|
let removed;
|
|
$our_reaction.parent()[0].remove = () => {
|
|
removed = true;
|
|
};
|
|
|
|
const message = {
|
|
id: message_id,
|
|
reactions: [
|
|
{
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: bob.user_id,
|
|
},
|
|
{
|
|
emoji_code: "1f44d",
|
|
emoji_name: "thumbs_up",
|
|
reaction_type: "unicode_emoji",
|
|
user_id: alice.user_id,
|
|
},
|
|
],
|
|
};
|
|
|
|
override_rewire(reactions, "update_vote_text_on_message", noop);
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.remove_reaction_from_view(clean_reaction_object, message, bob.user_id);
|
|
assert.ok(removed);
|
|
});
|
|
|
|
test("remove_reaction_from_view (last reaction)", () => {
|
|
const clean_reaction_object = {
|
|
class: "message_reaction",
|
|
count: 1,
|
|
emoji_alt_code: false,
|
|
emoji_code: "1f3b1",
|
|
emoji_name: "8ball",
|
|
is_realm_emoji: false,
|
|
local_id: "unicode_emoji,1f3b1",
|
|
reaction_type: "unicode_emoji",
|
|
user_ids: [],
|
|
};
|
|
const message_id = 507;
|
|
|
|
const $message_reactions = stub_reactions(message_id);
|
|
|
|
// Create a stub for the specific reaction
|
|
const $specific_reaction = $.create("specific-reaction-stub");
|
|
$message_reactions.set_find_results(
|
|
`[data-reaction-id='${CSS.escape("unicode_emoji,1f3b1")}']`,
|
|
$specific_reaction,
|
|
);
|
|
|
|
let removed = false;
|
|
$message_reactions[0].remove = () => {
|
|
removed = true;
|
|
};
|
|
|
|
const message = {id: message_id, reactions: []};
|
|
convert_reactions_to_clean_reactions(message);
|
|
reactions.remove_reaction_from_view(clean_reaction_object, message, bob.user_id);
|
|
assert.ok(removed);
|
|
});
|
|
|
|
test("bogus_event", ({override}) => {
|
|
// We don't expect errors when we process events with
|
|
// bad message ids.
|
|
override(message_store, "get", noop);
|
|
|
|
const bogus_event = {
|
|
message_id: 55,
|
|
reaction_type: "realm_emoji",
|
|
emoji_name: "realm_emoji",
|
|
emoji_code: "991",
|
|
user_id: 99,
|
|
};
|
|
reactions.add_reaction(bogus_event);
|
|
reactions.remove_reaction(bogus_event);
|
|
});
|
|
|
|
test("remove spurious user", ({override}) => {
|
|
// get coverage for removing non-user (it should just
|
|
// silently fail)
|
|
const message = sample_message_with_clean_reactions();
|
|
override(message_store, "get", () => message);
|
|
|
|
const event = {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "frown",
|
|
emoji_code: "1f641",
|
|
message_id: message.id,
|
|
user_id: alice.user_id,
|
|
};
|
|
|
|
reactions.remove_reaction(event);
|
|
});
|
|
|
|
test("remove last user", ({override, override_rewire}) => {
|
|
const message = sample_message_with_clean_reactions();
|
|
|
|
override(message_store, "get", () => message);
|
|
override_rewire(reactions, "remove_reaction_from_view", noop);
|
|
|
|
function assert_names(names) {
|
|
assert.deepEqual(
|
|
reactions.get_message_reactions(message).map((r) => r.emoji_name),
|
|
names,
|
|
);
|
|
}
|
|
|
|
assert_names(["smile", "frown", "tada", "rocket", "wave", "inactive_realm_emoji"]);
|
|
|
|
const event = {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "frown",
|
|
emoji_code: "1f641",
|
|
message_id: message.id,
|
|
user_id: cali.user_id,
|
|
};
|
|
reactions.remove_reaction(event);
|
|
|
|
assert_names(["smile", "tada", "rocket", "wave", "inactive_realm_emoji"]);
|
|
});
|
|
|
|
test("local_reaction_id", () => {
|
|
const reaction_info = {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_code: "1f44d",
|
|
};
|
|
const local_id = reactions.get_local_reaction_id(reaction_info);
|
|
assert.equal(local_id, "unicode_emoji,1f44d");
|
|
});
|
|
|
|
test("process_reaction_click", ({override, override_rewire}) => {
|
|
override_rewire(reactions, "remove_reaction_from_view", noop);
|
|
|
|
const message = sample_message_with_clean_reactions();
|
|
override(message_store, "get", () => message);
|
|
|
|
const expected_reaction_info = {
|
|
reaction_type: "unicode_emoji",
|
|
emoji_name: "smile",
|
|
emoji_code: "1f604",
|
|
};
|
|
|
|
// Test spectator cannot react.
|
|
page_params.is_spectator = true;
|
|
let stub = make_stub();
|
|
spectators.login_to_access = stub.f;
|
|
reactions.process_reaction_click(message.id, "unicode_emoji,1f604");
|
|
let args = stub.get_args("args").args;
|
|
assert.equal(args, undefined);
|
|
|
|
page_params.is_spectator = false;
|
|
stub = make_stub();
|
|
channel.del = stub.f;
|
|
reactions.process_reaction_click(message.id, "unicode_emoji,1f604");
|
|
assert.equal(stub.num_calls, 1);
|
|
args = stub.get_args("args").args;
|
|
assert.equal(args.url, "/json/messages/1001/reactions");
|
|
assert.deepEqual(args.data, expected_reaction_info);
|
|
});
|
|
|
|
test("code coverage", ({override}) => {
|
|
/*
|
|
We just silently fail in a few places in the reaction
|
|
code, since events may come for messages that we don't
|
|
have yet, or reactions may be for deactivated users, etc.
|
|
|
|
Here we just cheaply ensure 100% line coverage to make
|
|
it easy to enforce 100% coverage for more significant
|
|
code additions.
|
|
*/
|
|
override(message_store, "get", (id) => {
|
|
assert.equal(id, 42);
|
|
return {
|
|
clean_reactions: new Map(),
|
|
};
|
|
});
|
|
|
|
reactions.remove_reaction({
|
|
message_id: 42, // TODO: REACTIONS API
|
|
});
|
|
});
|
|
|
|
test("duplicates", () => {
|
|
const dup_reaction_message = {
|
|
id: 1001,
|
|
reactions: [
|
|
{emoji_name: "smile", user_id: 5, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
{emoji_name: "smile", user_id: 5, reaction_type: "unicode_emoji", emoji_code: "1f604"},
|
|
],
|
|
};
|
|
|
|
blueslip.expect("error", "server sent duplicate reactions");
|
|
convert_reactions_to_clean_reactions(dup_reaction_message);
|
|
});
|
|
|
|
test("process_reaction_click undefined", ({override}) => {
|
|
override(message_store, "get", () => undefined);
|
|
blueslip.expect("error", "reactions: Bad message id");
|
|
blueslip.expect("error", "message_id for reaction click is unknown");
|
|
reactions.process_reaction_click(55, "whatever");
|
|
});
|
|
|
|
test("process_reaction_click bad local id", ({override}) => {
|
|
const stub_message = {id: 4001, clean_reactions: new Map()};
|
|
override(message_store, "get", () => stub_message);
|
|
blueslip.expect("error", "Data integrity problem for reaction");
|
|
reactions.process_reaction_click("some-msg-id", "bad-local-id");
|
|
});
|